agens-no/AGGeometryKit

Memory leaks

Opened this issue · 2 comments

  1. "AGKMatrix.h"
- (NSNumber *)defaultMember {
	if (!_defaultMember) { // **Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue**
		_defaultMember = @0; 
	}
	
	return [_defaultMember copy];
}

- (void)resetMatrixToDefault:(NSNumber *)defaultValue {
    if (defaultValue) { // **Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue**
        self.defaultMember = defaultValue;
    }
	self.members = nil;
}

- (NSArray *)allMembers {
    NSMutableArray *allMembers = [NSMutableArray arrayWithCapacity:self.count];
    for (NSUInteger index = 0; index < self.count; index++) {
        [allMembers addObject:self[index]]; // **Argument to 'NSMutableArray' method 'addObject:' cannot be nil**
    }
    
    return allMembers;
}
  1. "UIImage+AGKQuad.h"
- (UIImage *)imageByCroppingToRect:(CGRect)rect
{
    CGImageRef croppedImage = CGImageCreateWithImageInRect([self CGImage], rect);
    return [UIImage imageWithCGImage:croppedImage scale:self.scale orientation:self.imageOrientation]; // **Potential leak of an object stored into 'croppedImage'**
}

Good catch! Do you have a pr handy? It may take a day or two before I can fix this

Good catch! Do you have a pr handy? It may take a day or two before I can fix this

No, I don't.