Missing Languages in New Polyglot Update.

Question

Missing Languages in New Polyglot Update.

AlexisDrain opened this issue 7 years ago · 7 comments

Polyglot was very recently updated where a new Master sheet was added.
https://docs.google.com/spreadsheets/d/17f0dQawb-s_Fd7DHgmVvJoEGDMH_yoSd8EYigrb0zmM/edit#gid=423963190

In my opinion, this will require changes in this repo:

A) In "LocalizationEditor.cs", the new default gid number should be changed from "296134756" to "423963190". The old number will download "Master_Old" and the new number will download "Master".

B) A few changes in "Langage.cs" are required in my opinion: "Language.cs" is not showing all the new languages in the correct order. This causes issues in "LocalizationImporter.cs". See 1-to-3 below:

Selecting the second-to-last language, "Arabic," gives an error because it is listed as number 28. Arabic should be ordered to be number 26, coming right after Hebrew. After doing this minor change, Arabic will become selectable in my tests.
Malay and Indonesian have been removed or renamed from the master sheet (?)
The last language in the new Master sheet, "Bosnian," is missing and unselectable in the "supported languages." I don't know how to fix this because I don't know what the correct equivalent for "SystemLanguage.Bosnian".

C) (extra) Update the repo to Unity 2017.2

PS. Correct me if I'm wrong about any of the above information. I've only looked at this project today, and I don't know the contribution policy for this plug-in.

Answer 1 · 2017-11-29T13:54:21.000Z

Hi, Tuomas Karmakallio here, editor of the Master Sheet I can put the refreshed sheet back in what I renamed to Master_Old to reduce impact of change. 1) Not sure what the issue is here. Old sheet ordering has not been changed, 2 new languages, Arabic and Bosnian have been added. 2 ) Malaysian and Indonesian columns are not included in Master because they are incomplete. 3) Same as 1? On Wednesday, November 29, 2017, 4:05:26 AM GMT+2, Alex Clay <notifications@github.com> wrote: Polyglot was very recently updated where a new Master sheet was added. https://docs.google.com/spreadsheets/d/17f0dQawb-s_Fd7DHgmVvJoEGDMH_yoSd8EYigrb0zmM/edit#gid=423963190 In my opinion, this will require changes in this repo: A) Update the repo to Unity 2017.2 B) In "LocalizationEditor.cs", the new default gid number should be changed from "296134756" to "423963190". The old number will download "Master_Old" and the new number will download "Master". C) A few changes in "Langage.cs" are required in my opinion: "Language.cs" is not showing all the new languages in the correct order. This causes issues in "LocalizationImporter.cs". See 1-to-3 below: - Selecting the second-to-last language, "Arabic," gives an error because it is listed as number 28. Arabic should be ordered to be number 26, coming right after Hebrew. After doing this minor change, Arabic will become selectable in my tests. - Malay and Indonesian have been removed or renamed from the master sheet (?) - The last language in the new Master sheet, "Bosnian," is missing and unselectable in the "supported languages." I don't know how to fix this because I don't know what the correct equivalent for "SystemLanguage.Bosnian". PS. Correct me if I'm wrong about any of the above information. I've only looked at this project today, and I don't know the contribution policy for this plug-in. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 2 · 2017-11-29T14:09:45.000Z

Nice to be notified of these issues, thanks! Updating the gid is a minor fix, but it would be nice if it stayed the same. As for the other issues, I’ll take a look at them and see what I figure out. I also have some other changes in the works.

…

On Wed, Nov 29, 2017 at 5:54 AM Karmington ***@***.***> wrote: Hi, Tuomas Karmakallio here, editor of the Master Sheet I can put the refreshed sheet back in what I renamed to Master_Old to reduce impact of change. 1) Not sure what the issue is here. Old sheet ordering has not been changed, 2 new languages, Arabic and Bosnian have been added. 2 ) Malaysian and Indonesian columns are not included in Master because they are incomplete. 3) Same as 1? On Wednesday, November 29, 2017, 4:05:26 AM GMT+2, Alex Clay < ***@***.***> wrote: Polyglot was very recently updated where a new Master sheet was added. https://docs.google.com/spreadsheets/d/17f0dQawb-s_Fd7DHgmVvJoEGDMH_yoSd8EYigrb0zmM/edit#gid=423963190 In my opinion, this will require changes in this repo: A) Update the repo to Unity 2017.2 B) In "LocalizationEditor.cs", the new default gid number should be changed from "296134756" to "423963190". The old number will download "Master_Old" and the new number will download "Master". C) A few changes in "Langage.cs" are required in my opinion: "Language.cs" is not showing all the new languages in the correct order. This causes issues in "LocalizationImporter.cs". See 1-to-3 below: - Selecting the second-to-last language, "Arabic," gives an error because it is listed as number 28. Arabic should be ordered to be number 26, coming right after Hebrew. After doing this minor change, Arabic will become selectable in my tests. - Malay and Indonesian have been removed or renamed from the master sheet (?) - The last language in the new Master sheet, "Bosnian," is missing and unselectable in the "supported languages." I don't know how to fix this because I don't know what the correct equivalent for "SystemLanguage.Bosnian". PS. Correct me if I'm wrong about any of the above information. I've only looked at this project today, and I don't know the contribution policy for this plug-in. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAitDdK38mNWi3Us2gFJnJ9OFjlP1bFiks5s7WIOgaJpZM4QuT2I> .

Answer 3 · 2017-11-29T14:48:19.000Z

I'll just copy over to the original, no problem. On Wednesday, November 29, 2017, 4:09:48 PM GMT+2, Skjalg Sturlasson Mæhre <notifications@github.com> wrote: Nice to be notified of these issues, thanks! Updating the gid is a minor fix, but it would be nice if it stayed the same. As for the other issues, I’ll take a look at them and see what I figure out. I also have some other changes in the works.

On Wed, Nov 29, 2017 at 5:54 AM Karmington ***@***.***> wrote: Hi, Tuomas Karmakallio here, editor of the Master Sheet I can put the refreshed sheet back in what I renamed to Master_Old to reduce impact of change. 1) Not sure what the issue is here. Old sheet ordering has not been changed, 2 new languages, Arabic and Bosnian have been added. 2 ) Malaysian and Indonesian columns are not included in Master because they are incomplete. 3) Same as 1? On Wednesday, November 29, 2017, 4:05:26 AM GMT+2, Alex Clay < ***@***.***> wrote: Polyglot was very recently updated where a new Master sheet was added. https://docs.google.com/spreadsheets/d/17f0dQawb-s_Fd7DHgmVvJoEGDMH_yoSd8EYigrb0zmM/edit#gid=423963190 In my opinion, this will require changes in this repo: A) Update the repo to Unity 2017.2 B) In "LocalizationEditor.cs", the new default gid number should be changed from "296134756" to "423963190". The old number will download "Master_Old" and the new number will download "Master". C) A few changes in "Langage.cs" are required in my opinion: "Language.cs" is not showing all the new languages in the correct order. This causes issues in "LocalizationImporter.cs". See 1-to-3 below: - Selecting the second-to-last language, "Arabic," gives an error because it is listed as number 28. Arabic should be ordered to be number 26, coming right after Hebrew. After doing this minor change, Arabic will become selectable in my tests. - Malay and Indonesian have been removed or renamed from the master sheet (?) - The last language in the new Master sheet, "Bosnian," is missing and unselectable in the "supported languages." I don't know how to fix this because I don't know what the correct equivalent for "SystemLanguage.Bosnian". PS. Correct me if I'm wrong about any of the above information. I've only looked at this project today, and I don't know the contribution policy for this plug-in. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAitDdK38mNWi3Us2gFJnJ9OFjlP1bFiks5s7WIOgaJpZM4QuT2I> .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 4 · 2017-11-29T15:31:19.000Z

Nice. I've now updated the project with the new language list.

Answer 5 · 2017-11-29T18:44:09.000Z

Thank you so much for the timely update!

However, I downloaded a fresh master branch of this repo and I am afraid to inform you that I cannot build project anymore! It gives me an error saying it's missing a TMPro. This did not happen yesterday before the current commit. I think the flag #if TMP_PRESENT isn't working anymore

I'm using Unity 2017.2.0f3 Personal.

Answer 6 · 2017-11-29T19:38:31.000Z

Sorry for the last comment! I solved my issue by consulting the readme file. I had to remove the TMP tag from "Player Settings > Other Settings > Scripting Define Symbols" which is currently enabled by default in the PolyglotUnity project.

Everything is working correctly now. Thanks again!

Answer 7 · 2017-11-29T21:33:52.000Z

Oops. I didnt mean to commit the changes to ProjectSettings. Nice that you fixed it.

…

On Wed, Nov 29, 2017 at 8:38 PM Alex Clay ***@***.***> wrote: Sorry for the last comment! I solved my issue after consulting with the readme file. I had to remove the *TMP* tag from *"Player Settings > Other Settings > Scripting Define Symbols"* which is currently enabled by default in the *PolyglotUnity* project. Everything is working correctly now. Thanks again! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAitDci02SDfX3wNQlU4g3If45GX1sjSks5s7bK4gaJpZM4QuT2I> .