ageron/handson-ml3

[IDEA] Remove sharex=False in figure 2-13?

oscark22 opened this issue · 1 comments

This isn't a bug, but rather a possible suggested improvement. In figure 2-13 the option sharex=False is used to handle a bug that used to occur in matplotlib.

The argument sharex=False fixes a display bug: without it, the x-axis values and label are not displayed (see: pandas-dev/pandas#10611).

That issue has been resolved. So there's no longer the need to include that argument. This is a possible improvement, the code still works perfectly.

I just noticed as well that this is now not needed.