Support better exception handling on parse
bsutton opened this issue · 3 comments
bsutton commented
Currently when parsing a schedule the cron library throws an Exception when a parse fails.
This is difficult to catch as it is too generic.
Can we replace this with a specific exception such as:
ScheduleParseException
ParseException
or maybe FormatException - not my preferred as it is used by other functions.
isoos commented
I'm down for ScheduleParseException extends/implements FormatException
. Are you interested creating a PR for it?
bsutton commented
I'm struggling for time at the moment so I'm going to have to say no.
…On Wed, 17 Nov 2021, 5:46 pm István Soós, ***@***.***> wrote:
I'm down for ScheduleParseException extends/implements FormatException.
Are you interested creating a PR for it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG32OEXA3JJKOZGQG7FL5LUMNFVJANCNFSM5IFWWSCA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
myConsciousness commented
I created the PR myself as it appears it has not been maintained for some time.
Please check back when you have time @isoos :)