agis/mcdetect

Particular issue with Google Mixed Content demo page

ashfame opened this issue · 6 comments

Hi @agis For any URL that I tested with, it works fast and the process ends right after showing the summary. But for this particular URL (the only URL I tested which has mixed content warnings), it hangs up before I get the Error: Navigation Timeout Exceeded: 30000ms exceeded error & then the process ends:

$ node -v && npm -v && ./bin/mcdetect.js https://googlesamples.github.io/web-fundamentals/fundamentals/security/prevent-mixed-content/active-mixed-content.html
v9.4.0
5.6.0
Checking https://googlesamples.github.io/web-fundamentals/fundamentals/security/prevent-mixed-content/active-mixed-content.html ...
	Blockable: http://googlesamples.github.io/web-fundamentals/samples/discovery-and-distribution/avoid-mixed-content/simple-example.js
	Blockable: http://googlesamples.github.io/web-fundamentals/samples/discovery-and-distribution/avoid-mixed-content/style.css
	Blockable: http://googlesamples.github.io/web-fundamentals/samples/discovery-and-distribution/avoid-mixed-content/xmlhttprequest-data.js
	Optionally Blockable: http://googlesamples.github.io/web-fundamentals/samples/discovery-and-distribution/avoid-mixed-content/puppy-thumb.jpg
	Error: Navigation Timeout Exceeded: 30000ms exceeded

Targets checked: 0
Errors (blockable content): 3
Warnings (optionally blockable content): 1

I spent the entire night on it yesterday, only to realize this is happening only with this URL. Or maybe it's happening with all of the mixed content warning pages. Got any clues?

agis commented

This actually puppeteer/puppeteer#1936. Not sure we can do something about it right now. Want to take a stab?

Ha, same issue at the same time :-)

It's a little above my pay grade right now 😅

For your information, my workaround looks like:

page._frameManager.on("lifecycleevent", frame => {
    if (frame._lifecycleEvents.has("networkIdle") && !frame._lifecycleEvents.has("load")) {
        // Mixed content error
    }
});
agis commented

@ashfame since the issue is fixed upstream, could you try with the latest puppeteer version?

@agis Yep, I was subscribed to issue filed on upstream. Going to check it and report back as soon as I can.