Install fails on node v10
Closed this issue · 3 comments
ptz0n commented
Installing & testing node-gyp
separately works just fine.
$ node --version && npm --version
v10.0.0
6.0.0
$ npm install
> mdns@2.3.4 install /Users/eng/Code/node_mdns
> node-gyp rebuild
CXX(target) Release/obj.target/dns_sd_bindings/src/dns_sd.o
In file included from ../src/dns_sd.cpp:1:
In file included from ../src/mdns.hpp:12:
In file included from ../node_modules/nan/nan.h:190:
../node_modules/nan/nan_maybe_43_inl.h:88:15: error: no member named 'ForceSet' in 'v8::Object'
return obj->ForceSet(GetCurrentContext(), key, value, attribs);
~~~ ^
…
Full debug log: https://gist.github.com/ptz0n/a209c2ce76ef8131253696320e306018
ylor commented
+1 also seeing this
kode54 commented
Affecting the "nan" module, which I see is using an interface that was deprecated in 2015:
I see the issue was already fixed, and mdns is intentionally using an old version.
I see #210 would also correct this, but nothing came from it after a comment suggesting more work was needed.
agnat commented
Fixed in v2.4.0: Node v10 should work fine now.