agrc/api-client

[Bug]: v1.7.0 built version does not run on intel macs

Closed this issue · 8 comments

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

App Version

1.7.0

Electron Version

??

Operating System

MacOS

What happened?

image

Steps To Reproduce

Open the app

Relevant log output

No response

The electron version should be 30 something I thought...

I'm not sure where I got that electron client number since the app won't even install. I'll remove it.

Should we pull this version?

It's hard to say. Do we want to support intel or apple silicon macs? I think that my vote would be to just add a note to the README about intel-based macs and point them at the older version. It appears to me that intel macs don't auto-upgrade to the unsupported version:
image

I'd like to figure out what caused changes to the support matrix. I wonder if it's the github hosted runners or new versions?

I assume that it was the switch from darwin to arm-based builds?

We didn't change anything in the code to explicitly specify ARM. We are still using the darwin token in the maker.

I think https://github.com/electron/universal is the solution.

This has been resolved.