seq66 does not recognize some changes for the save entry in the file menu

Question

seq66 does not recognize some changes for the save entry in the file menu

AndrewPy opened this issue 2 years ago · 5 comments

For example: If you change the velocity of some notes or change the set name, the save entry in the menu remains disabled. You must use the save-as entry.

Answer 1 · 2022-07-26T17:37:01.000Z

Thanks! Add any other "modify not working" issues to this ticket as you come across them. I have had that one my to-do list, but this will make me get to that task a lot faster.

…

For example: If you change the velocity of some notes or change the set name, the save entry in the menu remains disabled. You must use the save-as entry.

Answer 2 · 2022-07-27T18:25:57.000Z

I have basically fixed this issue. However, the live grid slots flicker as one moves the mouse to change velocity or moves the sliders in the LFO box. Both required the pattern editor to update, but not sure why the slots (all of them!) get updated. So some more probling to do. But see the latest portfix branch.

Answer 3 · 2022-07-28T09:09:57.000Z

Again, I don't know if this comment isn't for the wrong issue(?).

In any case, there is a difference between the active state of the save menu item and the save prompt when the program is closed. (I think they should be treated largely identically.)

Answer 4 · 2022-07-29T15:45:22.000Z

Still working on this one, now trying to get the Song Editor to show the modified status. Wotta pain! :-D

Answer 5 · 2023-09-05T12:58:52.000Z

I'm closing this. The current undo/redo/modify mechanism has been improved, but it cannot work completely. In a potential version 2, I am working on a more air-tight history mechanism based on the Memento/History patterns from Gamma et al. There won't be a Seq66v2 until I get a complete library that solves all the things that bug me about Seq66. And I might well croak or become senescent before that happens! :-D