ahmader/node-zoho

Ideas for implementing download[File/Photo]

Closed this issue · 2 comments

At this moment when I try execute downloadFile method via package I see that it happens error on response parsing stage because response tries to parse file body as XML and this caused error.

image

We've got content-type header in response and it is different than application/xml.

The correct expected result from this method is origin response body and parsed Content-Disposition header which easily can be done with this package

What do you think about the way of implementing this method?

@pahan35 Check #53
I have implemented downloadFile method. Also the tests pass for uploadFile, downloadFile and deleteFile.
I did not put it on master yet, tell me if it works with you?

@ahmader yes. This method works pretty well.

Thanks for your work.