ahudde/greeks

[internals] File greeks/src /BS_European_Greek_cpp.cpp ?

lrnv opened this issue · 3 comments

lrnv commented

This file is full of commented code. Why ? If this code has nothing to do here, simply remlove it (it still lives in your git history it is not lost).

ahudde commented

Good point, that draft doesn't have a purpose right now, I deleted it. b12788d

lrnv commented

It was a draft for future functionality ? In which case it probably belongs to its own brnach so that you can work on it without having to comment / uncomment it when you make releases.

ahudde commented

That's true, I should do that. In this case, I don't think I will pursue this.

  • 👍1