Feedback / Code Review

[bgveenstra]

Technical Requirements

Meets requirements. Exceeds expectations.

You completed the technical requirements. Cool use of the * CSS selector to target all elements, but it doesn't seem like leaving it blank is having any effect. Check out CSS tricks for an article on how to get a static full page background image .

You minimized the use of global variables by keeping your code inside the callback to the document-ready event handler. It works well here. As projects get bigger, it may make sense to move some of the code out and encapsulate it in separate functions. There's a tension between minimizing global variables and keeping code modular.

Some of your event handlers are attached (with on) inside functions. This works for your keyUp event listener because the function it's inside of (keyStroke) gets called. On the other hand, your #search-form submit handler is attached inside an avatar function. The avatar function never gets called, so the event listener never actually gets attached.

Creativity

Meets expectations.

For the UI, fun default sloth image. Race track and text color are hard to see against the background. To improve user experience, consider adding instructions for each player to let them know which key to press, how to win, etc. For the code, there's a lot of cool ideas there and a good skeleton to build from.

Code Quality

Does not meet expectations.

Your code is well-commented, and your variable names make the code easier to read. However, if you're cleaning this up for your portfolio it would benefit from another pass to clean up unused code and fix indentation. I like that you built out skeletons of the methods you knew you'd need, with planning comments, and filled them in later. When we learn about git branching, you can do some of this work on a non-master branch so that your primary code base stays clean.

Overall

Your game is technically complex and well done! You planned a bit more than you were able to accomplish in the time, but your approach was excellent as you were able to meet the project minimums. I think your Spotify plan would have worked if you'd attached the event handlers in the correct place.