TypeError: UPower is undefined

Question

TypeError: UPower is undefined

enku opened this issue 3 years ago · 8 comments

Upgraded to version 24 on GNOME 42. Not sure why this is happening but

JS ERROR: TypeError: UPower is undefined
update/<@/home/marduk/.local/share/gnome-shell/extensions/autohide-battery@sitnik.ru/extension.js:22:25
getBattery@/home/marduk/.local/share/gnome-shell/extensions/autohide-battery@sitnik.ru/extension.js:39:13
update@/home/marduk/.local/share/gnome-shell/extensions/autohide-battery@sitnik.ru/extension.js:21:13

Although UPower seems to be defined on line 2. I've tried UPower = imports.ui.status.power.UPower on the Looking Glass prompt and get an object. Could there be some kind of race?

Answer 1 · 2022-03-25T11:51:51.000Z

Very strange. Sorry, I have no idea.

Answer 2 · 2022-03-25T11:59:21.000Z

(re)importing upower after line 19 works around the issue.

Answer 3 · 2022-03-25T12:01:46.000Z

Can you try this hack?

const ExtensionUtils = imports.misc.extensionUtils
- const UPower = imports.ui.status.power.UPower
+ const Power = imports.ui.status.power
const Main = imports.ui.main

let batteryWatching, settingsWatching, settings, disabled

function show() {
  getBattery((proxy, icon) => {
    icon.show()
  })
}

function hide() {
  getBattery((proxy, icon) => {
    icon.hide()
  })
}

function update() {
  let hideOn = settings.get_int('hide-on')
  getBattery(proxy => {
-    let isDischarging = proxy.State === UPower.DeviceState.DISCHARGING
-    let isFullyCharged = proxy.State === UPower.DeviceState.FULLY_CHARGED
-    if (proxy.Type !== UPower.DeviceKind.BATTERY) {
+    let isDischarging = proxy.State === Power.UPower.DeviceState.DISCHARGING
+    let isFullyCharged = proxy.State === Power.UPower.DeviceState.FULLY_CHARGED
+    if (proxy.Type !== Power.UPower.DeviceKind.BATTERY) {
      show()
    } else if (isFullyCharged) {
      hide()
    } else if (proxy.Percentage >= hideOn && !isDischarging) {
      hide()
    } else {
      show()
    }
  })
}

Answer 4 · 2022-03-25T12:34:23.000Z

Can you try this hack?

Yes, that works too. So seems like some race between when UPower is defined in power and when it is referenced in update().

Answer 5 · 2022-03-25T12:36:42.000Z

Great. I will release a fix in an hour. If you want, you can send PR to save your name in the project history.

Answer 6 · 2022-03-25T13:41:01.000Z

Actually I think it's still failing on on the initial update() but works in the subsequent callbacks. When I look at the extensions app it shows as failed with the undefined error yet it still "works" because the callbacks are registered before the first update().

Answer 7 · 2022-03-25T14:33:10.000Z

We can add if (Power.UPower) check to update

Answer 8 · 2022-03-25T15:14:55.000Z

Version 25 was pushed to https://extensions.gnome.org/extension/595/autohide-battery/

Feel free to open new issue if you find a problem.