aiidateam/aiida-wannier90

Add tests (travis)

giovannipizzi opened this issue · 7 comments

Add tests with travis, including documentation compilation, and checking that load_dbenv() is not needed to do a "bare" import aiida_wannier90

To clarify (after discussing with Giovanni): It's ok if import aiida_wannier90 fails when the dbenv is not loaded (although we might still choose to make this work). The important part is that the plugin does not try to load the dbenv.

@greschd can you try to add a simple travis test, if you happen to have time?
BTW, for now we cannot use the plugin fixtures because they are not in 0.10.0 but only in develop, and we cannot make this plugin depend on it...

I'll look into it. Not quite sure if aiida-pytest works nicely with Travis right now, but it should be doable.

@giovannipizzi Could you enable Travis for aiida-wannier90? It seems I don't have the rights to do that.

Just did, with the option "build only if .travis.yml is present"

Perfect, thanks.

Added a Travis run, which clones and compiles Wannier90 and then runs the local tests. Since it needs the AIIDA_PATH feature, aiida-core is currently installed from GitHub as well, but that can be changed after the 0.10 release.

Also had to fix the tests and the parser, due to the change from KpointsData to ParameterData in the kpoint_path variable.

Finally, added YAPF formatting, which accounts for most of the changes in the code.