aio-libs-abandoned/aioredis-py

ConnectionResetError / Catch OSError in get_connection

ap1erce opened this issue · 3 comments

ap1erce commented

Describe the bug

aioredis.exceptions.ConnectionError is a custom exception that does not catch built-in python ConnectionErrors. As a result, Connection.get_connection may return broken/invalid connections.

To Reproduce

See redis/redis-py#1772

Expected behavior

Connection.get_connection should catch OSError in addition to aioredis.exceptions.ConnectionError

Logs/tracebacks

N/A

Python Version

$ python --version
v3.6.9

aioredis Version

$ python -m pip show aioredis

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
ap1erce commented

See #1324

I believe this also solves #1313 and #1314 while keeping in-line with redis-py

jonathansp commented

updates on this?

ap1erce commented

@jonathansp aioredis has been merged into redis-py and is now deprecated. The async redis-py module has this fix.