aio-libs/create-aio-app

Add params for makefile

Arfey opened this issue · 26 comments

Arfey commented

Will be great have approach to put some arguments for make test or commands some like this.

For that we need add some like that into Makefile.

# arguments
FIRST_ARG := $(firstword $(MAKECMDGOALS))
ARGS = $(filter-out $@,$(MAKEOVERRIDES) $(MAKECMDGOALS))
MAKEFILE_PATH := $(abspath $(firstword $(MAKEFILE_LIST)))

%:
	@:

and after that add ${ARGS} to our commands

test:
	docker-compose run --rm app-test ${ARGS}

usage

make test -- my_param=some_param othe_param

u need:

  • generate ARGS variable
  • add this variable to all commands which need it
  • describe that into documentation
ranveersequeira commented

I'm new in open source.
Can I start to work on this?

Arfey commented

Sure. i'll what ur MR 😀

ranveersequeira commented

I'mean I've just started today.
Do you think I can do that?
Just forked this and checking whole codebase

Arfey commented

Who know, but i'll believe in u 😂
I think so this article will help u
https://opensource.com/article/19/7/create-pull-request-github

  • 😄1
ranveersequeira commented

Sir, I mean what i supposed to know to get started?

Arfey commented

This task connected only with this file.

https://github.com/aio-libs/create-aio-app/blob/master/create_aio_app/template/%7B%7Bcookiecutter.project_name%7D%7D/Makefile

Here u can see all useful information for contributor.

https://github.com/aio-libs/create-aio-app/blob/master/CONTRIBUTING.md

if that's not what you want to know, please explain better.

  • 👍1
faraz16iqbal commented

Is this issue still open?

mahendra1290 commented

Is this issue still open ?

mahendra1290 commented

Can i work on this ?.

Arfey commented

sure

Deleted user commented

Is this still open? And can I work on this?

Deleted user commented

Okay. I am a beginner tho in open source. What do I need to do? I have cloned it. And I have tried to run make test on my windows But it is not working.

Arfey commented

u can pass output from ur terminal and we can try to help with that.

Deleted user commented
Arfey commented

Could u please use GitHub web interface for send screenshot because i can't open maketest.png :(

marcosmamg commented

Please assign it to me

Arfey commented

if u have a time then MR welcome

HenriGourgue commented

I would like to work on this as my first contribution, is it open?

Arfey commented

sure)

HenriGourgue commented

I worked on this issue. I've made something like that :
$make upgrade ARGS="test1 test2 test3 test4"

output
docker-compose run --rm riton6_app python3 -m riton6.utils.check-requirements test1 test2 test3 test4

Is it what you were waiting for ?
If it is not, could you please be more specific ?

PrithviRana1 commented

Is this still open?

Arfey commented

Hi, i think so yes. the version with ARGS= doesn't look like so good solution. in description for this issue we have solution which cover all cases

rawatsushil commented

@Arfey Hey I have done the changes in my local, i would like to create a PR for this

  • 👍1
tesknight commented

is this issue still open?

tonguegrease commented

New contributor here! If this is still open I'd like to work on this.