airbnb/ruby

[bug] Update rubocop to 1.6.2

hjkatz opened this issue · 2 comments

Release 1.6.1 includes an incorrect autocorrect for rule Layout/SpaceInsideHashLiteralBraces and y'all's recent release to rubygems.org has introduced this for our builds (and possibly others).

See: https://github.com/rubocop/rubocop/releases/tag/v1.62.0

See fix: rubocop/rubocop#12736

Errors look like:


lib/redacted/services/redacted_spec.rb:37:25: C: [Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside empty hash literal braces detected.
--
  | replacements = { ...

...

@hjkatz I'm assuming you mean 1.61.0?

#206 doesn't constrain rubocop to equal 1.61.0; instead we constrain rubocop to be at least 1.61.0. You should be able to bundle update rubocop. This gem won't restrict you from upgrading to 1.62.0!

Yes that's right, sorry I mistyped the version.

I'm not super familiar with ruby, and I'll look into the version constraint on our end. For now I at least wanted to report something on the internet :)