airbnb/ts-migrate

JSDoc plugin appears to not work after v0.1.22

sawyerh opened this issue · 4 comments

sawyerh commented

Hi, after upgrading from ts-migrate v0.1.22 to v0.1.25-v0.1.26, the jsdoc plugin no longer runs on the expected files.

Here is a repo showing a simplified example.

Given a repo like the above, v0.1.22 would migrate the JSDoc comments in src/js-doc-example.ts when I ran:

ts-migrate migrate . --plugin jsdoc

TypeScript version: 4.2.4
Initialized tsserver project in 160ms.
Start...
[jsdoc] Plugin 1 of 1. Start...
[jsdoc] Finished in 4ms.
Finished in 4ms, for 1 plugin(s).
Writing 1 updated file(s)...
Wrote 1 updated file(s) in 2ms.

However, with v0.1.26, no files are processed:

TypeScript version: 4.4.4
Initialized tsserver project in 162ms.
Start...
[jsdoc] Plugin 1 of 1. Start...
[jsdoc] Finished in 1ms.
Finished in 2ms, for 1 plugin(s).
Writing 0 updated file(s)...
Wrote 0 updated file(s) in 1ms.
sandinmyjoints commented

Looking at v0.1.22...v0.1.25, I see that 25dbf58 made changes to the jsdoc plugin. The diff is quite big, and the commit messages is just "fixes", so it's hard to know what's going on there.

sandinmyjoints commented

(FWIW, npx ts-migrate@0.1.22 migrate . --sources="whatever/*.ts" --plugin jsdoc works.)

  • 👍1
  • 🎉1
kotmatpockuh commented

is it still working @sandinmyjoints ?
tried - but no luck