airbrake/javabrake

Proxy

simonwacker opened this issue · 3 comments

simonwacker commented

Hallo!

How can I use Javabrake behind a proxy? Is there a way to configure the proxy setting of OkSender.okhttp?

Best regards,
Simon.

vmihailenco commented

Hallo!

We could add some option like Notifier.setProxy, but it looks like I am just monkey-wrapping okhttp API. I guess the best solution would be to expose OkSender.okhttp instance to the users - I am just not sure how to do it right in Java idiomatic way. Suggestions are welcome.

vmihailenco commented

PS My current plan is

  • make OkSender, OkSyncSender and OkAsyncSender public
  • add public static method OkSender.setOkHttpClient

and then you have full control over okhttp client

simonwacker commented

Great to hear back from you! I reckon a public setOkHttpClient method is a Java idiomatic way. It would be great to also have a getOkHttpClientBuilder method that returns an OkHttpClient.Builder instance with sensible defaults for connect, read, and write timeouts.