JSONC support is bugged
lucascolley opened this issue · 1 comments
lucascolley commented
@HaoZeke there was an oversight in my PR - the default is actually defined at the level of the command as well as in config.py
:
asv/asv/commands/common_args.py
Lines 26 to 29 in bc2d07e
I think we should make it so that the command defaults to None
, and let config.py
handle the None
?
HaoZeke commented
@HaoZeke there was an oversight in my PR - the default is actually defined at the level of the command as well as in
config.py
:asv/asv/commands/common_args.py
Lines 26 to 29 in bc2d07e
I think we should make it so that the command defaults to
None
, and letconfig.py
handle theNone
?
Sure that makes sense. Sorry I didn't catch it in the review.