airspeed-velocity/asv

JSONC support is bugged

lucascolley opened this issue · 1 comments

@HaoZeke there was an oversight in my PR - the default is actually defined at the level of the command as well as in config.py:

parser.add_argument(
"--config",
help="Benchmark configuration file",
default=(argparse.SUPPRESS if suppress_defaults else 'asv.conf.json'))

I think we should make it so that the command defaults to None, and let config.py handle the None?

@HaoZeke there was an oversight in my PR - the default is actually defined at the level of the command as well as in config.py:

parser.add_argument(
"--config",
help="Benchmark configuration file",
default=(argparse.SUPPRESS if suppress_defaults else 'asv.conf.json'))

I think we should make it so that the command defaults to None, and let config.py handle the None?

Sure that makes sense. Sorry I didn't catch it in the review.