Pick for trees - Pull request?
Closed this issue · 5 comments
So... I needed pick for tree structures. So I made the necessary changes. And then I made some more.
It was supposed to be just a small pull request, but it turned into a project of its own, so here is my question: would you like me to make my fork into a pull request?
I've released it as its own package for now, because I needed it up for the project that originated it all, but I'll be happy to contribute upstream! I just don't know if it's too far from the original scope of your project at this point.
In any case, thank you so much for this picker! Your code saved me a lot of trouble and time.
Hi anafvana, your fork looks powerful indeed! However, it seems out of the scope of pick, a simple library to select from a list of data. So I'd suggest not integrating tree selecting in this repo. But I'd be happy to add a link to your project in README
Then we leave them unmerged and I leave my huge thanks to you for giving me the basis for pickpack!
And if you want to link to the tree version in your README, I will be grateful for the free advertisement! (Although you are not in any way obliged to do it)
Yeah I've added it. https://github.com/wong2/pick#community-projects=
I ended up having another use case and developing another fork of pick, this time for assigning options to groups.
I'm here, as always, to send you a huge thanks (I wouldn't have done this without your pick) and to share it in case anyone ever has a use case for it: groupick
Nice job!