PHP 7.4 support
Opened this issue · 2 comments
When I try to install the extension via composer I got:
[InvalidArgumentException]
Package aitoc/smtp at version has a PHP requirement incompatible with your PHP version (7.4.10)
Unfortunately there is an actual incompatibility in the code somewhere. When I edited the composer.json file manually to allow for PHP 7.4, running php bin/magento setup:di:compile gives an error:
jared@ip-172-31-22-3:/var/www/newsite# sudo -u www-data php bin/magento setup:di:compile Compilation was started. Repositories code generation... 1/8 [===>------------------------] 12% < 1 sec 79.0 MiBPHP Fatal error: Uncaught Error: Interface 'Aitoc\Smtp\Api\Data\LogInterface' not found in /var/www/newsite/app/code/Aiotic/Smtp/Model/Log.php:8 Stack trace: #0 /var/www/newsite/setup/src/Magento/Setup/Module/Di/Code/Reader/ClassesScanner.php(136): require_once() #1 /var/www/newsite/setup/src/Magento/Setup/Module/Di/Code/Reader/ClassesScanner.php(117): Magento\Setup\Module\Di\Code\Reader\ClassesScanner->includeClass() #2 /var/www/newsite/setup/src/Magento/Setup/Module/Di/Code/Reader/ClassesScanner.php(87): Magento\Setup\Module\Di\Code\Reader\ClassesScanner->extract() #3 /var/www/newsite/setup/src/Magento/Setup/Module/Di/App/Task/Operation/RepositoryGenerator.php(61): Magento\Setup\Module\Di\Code\Reader\ClassesScanner->getList() #4 /var/www/newsite/setup/src/Magento/Setup/Module/Di/App/Task/Manager.php(56): Magento\Setup\Module\Di\App\Task\Operation\RepositoryGenerator->doOperation() #5 /var/www/newsite/setup/src/Magento/Setup/Console/Command/DiCompileCommand.php(206): Magento\Setup\Module\Di\App\Task\Manager->process() #6 /va in /var/www/newsite/app/code/Aiotic/Smtp/Model/Log.php on line 8
I'll look into the code this afternoon and see if I can find the cause of the issue.
Unfortunately there is an actual incompatibility in the code somewhere. When I edited the composer.json file manually to allow for PHP 7.4, running php bin/magento setup:di:compile gives an error:
jared@ip-172-31-22-3:/var/www/newsite# sudo -u www-data php bin/magento setup:di:compile Compilation was started. Repositories code generation... 1/8 [===>------------------------] 12% < 1 sec 79.0 MiBPHP Fatal error: Uncaught Error: Interface 'Aitoc\Smtp\Api\Data\LogInterface' not found in /var/www/newsite/app/code/Aiotic/Smtp/Model/Log.php:8 Stack trace: #0 /var/www/newsite/setup/src/Magento/Setup/Module/Di/Code/Reader/ClassesScanner.php(136): require_once() #1 /var/www/newsite/setup/src/Magento/Setup/Module/Di/Code/Reader/ClassesScanner.php(117): Magento\Setup\Module\Di\Code\Reader\ClassesScanner->includeClass() #2 /var/www/newsite/setup/src/Magento/Setup/Module/Di/Code/Reader/ClassesScanner.php(87): Magento\Setup\Module\Di\Code\Reader\ClassesScanner->extract() #3 /var/www/newsite/setup/src/Magento/Setup/Module/Di/App/Task/Operation/RepositoryGenerator.php(61): Magento\Setup\Module\Di\Code\Reader\ClassesScanner->getList() #4 /var/www/newsite/setup/src/Magento/Setup/Module/Di/App/Task/Manager.php(56): Magento\Setup\Module\Di\App\Task\Operation\RepositoryGenerator->doOperation() #5 /var/www/newsite/setup/src/Magento/Setup/Console/Command/DiCompileCommand.php(206): Magento\Setup\Module\Di\App\Task\Manager->process() #6 /va in /var/www/newsite/app/code/Aiotic/Smtp/Model/Log.php on line 8I'll look into the code this afternoon and see if I can find the cause of the issue.
@jmelkun I think you may have written this so early, but now it's working fine after updating the composer file. anyway, I've created a pull request for this, I wish they will pay attention.