akioweh/EducationPerfected

no need for auto browser download

akioweh opened this issue · 2 comments

@garv-shah i was looking at the changes when you fixed sso login (3256bd9)

I see that you have added some lines that downloads a browser
is it really necessary? because npm i puppeteer will install a bundled chromium browser, which should always work anyway

i think it's a MacOS thing with chromium, cause it worked fine for me on windows but on MacOS it told me that it could only run on chromium revision something, so adding in the auto-download line fixed it on MacOS
I think it should be fine either way, since it doesn't seem to install another browser if the bundled browser already works :D

i see, all good then :)