akonwi/git-plus

support submodules

Closed this issue · 8 comments

maxheld83 commented

it appears that git-plus may, as of yet, not support submodules.
It'd great to see that and/or a confirmation that the below behaviour is in fact due to the lack of submodule support in git-plus (as opposed to somewhere else in the stack).

I first posted the below on the atom forums but someone suggested this might be the place:

I'd like to able to use submodules efficiently within Atom.

Use case file tree:

  • superproject
    • submodule1
      • file-a
    • submodule2
    • file-b
    • folder1

Expected behavior:

I'd like to able to select submodule1 (which, after all, includes a .git) or any folder or file therein (such as file-a) and be able to then have any add, commit and push etc. commands I do (with, say, git-plus) to apply to the submodule.

* Observed behavior:*

No matter where I am, any git operations will work only on the superproject.

In fact, if I just open the submodule1, edit, add and commit I get this:

Window load time: 1625ms /Applications/Atom.app/Contents/Resources/app/src/window-bootstrap.js:18
4
Uncaught Error: EEXIST, file already exists '/Users/Max/Github/barjoke/latexstyles/.git' /Users/Max/.atom/packages/git-plus/node_modules/fs-plus/node_modules/mkdirp/index.js:76

Any thoughts on how to handle this problem and submodules in general?

akonwi commented

I think compatibility with submodules is possible. Right now, the package just wants to know whether the atom project is a git repo or not. That can change to work per file. I'll experiment with it to make sure it doesn't break everything else

maxheld83 commented

fantastic, great to hear, @akonwi!

akonwi commented

Just published an update with submodule support. Give it a shot and let me know if it works for you

ionutzp commented

@akonwi still having this issue with Git Plus 4.1.2

Uncaught Error: EEXIST, file already exists '[...]/.git' /Applications/Atom.app/Contents/Resources/app/node_modules/mkdirp/index.js:76

akonwi commented

@ionutzp Someone else had this issue. After he deleted the repo locally and got a fresh clone, it was working again

devfoo-one commented

@ionutzp i had kinda weird issues after the 4.1.2. update. After deleting the package via the atom package manager and reinstalling it worked fine again.

ionutzp commented

Okay, cool i will try it

On Thu, Oct 23, 2014 at 10:58 AM, Tom Oberhauser notifications@github.com
wrote:

@ionutzp https://github.com/ionutzp i had kinda weird issues after the
4.1.2. update. After deleting the package via the atom package manager and
reinstalling it worked fine again.

—
Reply to this email directly or view it on GitHub
#48 (comment).

Ionuţ Popa
twitter: @ionutzp http://twitter.com/#!/ionutzp
tumblr: http://ipopa.tumblr.com/

xyzzy529 commented

Whatever happened with this?
I am having what sounds like the same problem. Submodules have Git repos and none of the line diff is working in any of the submodules or main root code.

  • 👍1