akonwi/git-plus

git push doesn't push, leaves blank empty line below atom status bar

Closed this issue · 13 comments

I assume some kind of error is being thrown, but I'm not seeing any, I hit Ctrl+Shift+H and type "Push", then select it with when it's displayed, but all that happens is a push icon appears and the status bar moves up one line. When I look at the status in TortoiseGit, the push hasn't happened.

Open the developer console and see if there is any feedback there when you push. If there is, can you share a screenshot?

I published an update yesterday but there were no changes to the push feature and pushing is working for me.

I'm also getting this issue (on Windows), I opened the developer console and pushed, but no output was printed.

Yes, I'm on Windows as well. There's no out put in the developer console, just an additional black line below the status bar appears.

One thing I did find was that running git push in the console prompted me to trust the SSH fingerprint of my server, however I have now done this and the issue persists within atom.

That's odd. I'll install it on a windows computer and try to debug from there

If it helps reproduce the issue, my git origin is a "git@" type SSH clone, using SSH key authentication.

I use that too and have no problems at all with pushing. Do you have a known_hosts file under $HOME/.ssh/? If yes, is the server in there? Do you have to accept the hash every time you try to push from CLI?

No, I have already accepted the host key and I am not asked for it on
subsequent pushes, and although I am on Windows, git has indeed added a
known_hosts file to .ssh and added the server's fingerprint to it.

hmm... Multiple git executeable paths? Is GIT_SSH configured accordingly?

GIT_SSH is not set. Is there an way to find out what git executable the plugin is using? I'm only aware of having one...

Google and set GIT_SSH accordingly. I think node starts the child_process, that calls git, but because git is not started from your prepared terminal it does not know which SSH client it should use and... fails

Nope, I've just tried setting that and launching atom from the same session in which I set it, as well as setting in the Environment Variables GUI and relaunching atom, and the same error occurs.

That said, it's working now. I had added and then removed the GIT_SSH variable, but now I'm getting output displayed. I don't know what happened, but it's working now...

Haha awesome.