akxcv/vuera

Don't pass `children` to React component if not present

thany opened this issue · 0 comments

thany commented

Consider this React component called in a Vue template:

<hello-from-react />

Couldn't be simpler. But it passes children which aren't there at all. Using forbidExtraProps from airbnb-prop-types it fails prop-type validation.

Please ONLY pass children if a component has content, a <slot>, or an explicit children prop.

Same problem occurs in that other superfluous prop.