alankan886/SuperMemo2

Improve tests under test_api.py

Closed this issue · 1 comments

alankan886 commented

User Story

As a developer, I want stronger tests for first_review and modify in test_api.py, so that I can rely more on the tests.

Description

Tests for first_review and modify aren't checking current values.

Especially with the modify method, the current values update correspond to changes in the previous values. I think it's important to check if the current values have been updated correctly.

Acceptance Criteria

  • All tests under test_api.py besides test_modify_no_inputs checks current values.

Steps

  1. Find the expected values in test_sm_two.py or calculate them.
  2. Add expected values into test cases for each test.
  3. Add asserts checking the current value against the expected values.
alankan886 commented

Closing this issue since I'm planning to roll out a v2.0.0.