alankan886/SuperMemo2

E-Factor not calculated when q < 3

Closed this issue · 4 comments

alankan886 commented

I had some misunderstanding of the explanation of the algorithm, EF factor should always be calculated for every quality value.

I thought If the quality response was lower than 3 then start repetitions for the item from the beginning without changing the E-Factor means not to calculate a new EF factor, but it really means reset the repetitions and keep the new E-Factor.

Zhuo-Ren commented

I am also very curious about this issue. In your code, you keep updating this E-Factor, regardless of whether the score is less than 3. Is there any relevant evidence? I can't get the corresponding paper.

alankan886 commented

Hey @Zhuo-Ren,

Thanks for the comment. So my changes are based on the algorithm description, the implementation and an answer I got from emailing help2021@supermemo.org.

And it seems like if E-Factor doesn't update when q is less than 3, then 0 to 2 as q would be making identical impacts.

But definitely correct me if you think I'm missing something, and let me know if this makes sense.

Zhuo-Ren commented

Thanks for your replay @alankan886.
I think you are right after reading the delphi implementation that you mentioned. It helps alot. 😄

  • 👍1
alankan886 commented

@Zhuo-Ren I'm glad I can help!