alchemyEngine/measure_thermal_behavior

Using any integer larger than 0 for COOL_DURATION likely results in the script running a whole day

Scroey opened this issue · 2 comments

Probably faulty math or wrong moment to evaulate the term.

wtf minutes
The error is likely in

while((datetime.now() - start_time) < timedelta(hours=HOT_DURATION+COOL_DURATION)):

I used HOT_DURATION = 3 and COOL_DURATION = 1
Error occurred both when the end of the measurement would have been just after midnight and in the middle of the day, so it is probably not a calendar-day related issue.

@Scroey It looks like to me like it's just a problem with calculation of the remaining time to print..

Did it actually run beyond the expected completion time, or did you cancel it?

With the prospect of it taking a whole day I killed the run both times this was happening half an hour early. I'll keep it running next time. Thank you for investigating.