XK is missing

Question

Closed this issue 2 months ago · 11 comments

XK is missing, which is the code of Kosovo. Would it be possible to add it?

Answer 1 · 2024-02-19T12:00:36.000Z

It's part of the user assigned codes, which so far I have intentionally not implemented.

I can add a decorator that offers the extended codes, similar to how the aliases decorator works (but different).

Answer 2 · 2024-10-09T13:28:20.000Z

I created the PR #109 - checkout

Answer 3 · 2024-10-10T07:24:18.000Z

While I am still not sure if it belongs in the main dataset; I have no strong objections to adding it I guess.

Answer 4 · 2024-10-10T07:29:46.000Z

I think adding a decorator will help, because sometimes companies like Mastercard support different codes, and you have to support it somehow
See: https://developer.mastercard.com/card-issuance/documentation/code-and-formats/iso-country-and-currency-codes/
not all codes from the link are correct.

EDIT: example: in Mastercard Kosovo has: Kosovo 900 QZ QZZ

Answer 5 · 2024-10-10T07:35:00.000Z

I think that is something that belongs in userland code though, not this library.

Answer 6 · 2024-10-10T07:39:50.000Z

Of course, but the easiest way would be to inherit ISO3166, but it is final now

Answer 7 · 2024-10-10T07:43:05.000Z

Yes, that is intentional.

Answer 8 · 2024-10-11T10:49:16.000Z

I see release 4.3.2 with Kosovo, but in https://packagist.org/packages/league/iso3166 version is not updated. Can you refresh it?

Answer 9 · 2024-10-11T11:13:19.000Z

I don't release as league anymore, sorry.

Answer 10 · 2024-10-11T11:23:46.000Z

Ah wait, it was simply pointing to the wrong repo. I think it's resolved now.

Answer 11 · 2024-10-11T11:59:38.000Z

composer update successfully 😄
Thakns 🎉 💪🏼