alecthomas/chroma

LineHighlight style is incorrect

jmooring opened this issue · 5 comments

jmooring commented

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

There are currently 5 styles that specify LineHighlight:

In each case, the resulting style is #HEXCODE instead of bg: #HEXCODE.

cc: @icy-comet

To Reproduce

Not applicable because the playground does not allow you to specify which lines to highlight.

alecthomas commented

Contributions are welcome.

jmooring commented

@alecthomas Understood. My understanding is that these styles are generated, not hand coded. I don't spend enough time in the codebase to know where to start. I cc'd icy-comet because it looks like they were the last one to touch all five styles.

alecthomas commented

They're not generated, they're XML files in this directory: https://github.com/alecthomas/chroma/tree/master/styles

jmooring commented

#797 (comment)

These definitions have been dynamically created using a script to keep up with changes in the color pallete.

I'd hate to make changes just to have them overwritten the next time someone uses the script referenced above.

icy-comet commented

the script referenced above

It's an external script I use to keep the styles up-to-date with the upstream color definitions and is entirely independent of chroma.

Anyways, I have updated the template in my repo and also opened a PR here.