alejandropoveda/atom-language-gsql

GSQL Non-Reserved Keywords

Opened this issue · 2 comments

Hey Alejandro!
Me again... :)

I've noticed that the plugin changes the case of GSQL keywords to capital (in addition to giving them a distinctive color).
That's really nice, but there's a problem with the GSQL Non-Reserved Keywords

As the manual says: "users may use them for user-defined identifiers".
And we actually do use "user" as a name of one of our vertices.
So, when I write a GSQL query that refers to these vertices, the case changes, and it breaks the query (vertex types are case sensitive).

I think that it may be better not to apply the logic relevant to "GSQL Reserved Words" on "GSQL Non-Reserved Keywords" .

What do you think?

Thanks for your time!
Denis

Hello Denis!
Glad to talk to you again.

Yes, I think you are right. I think that i've got the idea but if you don't mind, could you send me an example query to see how are you using it?.

Also, I coded the plugin like one year and a half ago and I skip some parts of the DML and DDL. So please, tell me all the issues that you are finding out and i will be glad to look into it. Every contribution is greatly appreciated :)

Thanks to you,
Alejandro.

Hi Alejandro!

So, here's an example of what I meant:
We have a Vertex in the graph that is called "user".
So, when I write the following INSERT statement:
INSERT INTO user VALUES ("x" ,"y", "z");
the plugin converts it to upper-case, and colors it blue, like so:
image

The expected behavior would be like the one in the bottom row - the "fraud" example.

Hope this example is helpful...

Thank you very much again! I'm enjoying your plugin very much! 😺

Best regards,
Denis