alekseyl/rails_select_on_includes

Can we have comma only separator?

mlt opened this issue · 3 comments

mlt commented

I'm talking about

rails_select_on_includes/lib/rails_select_on_includes.rb

Line 35 in 08f9429

sv.split( ", " ).each do |sub_sv|

As of now expressions like

  @stuff = Mymodel.join(my_arel.join_sources)
    .select('some.stuff,
    other.stuff')

are broken if there is no space after some.stuff,.

alekseyl commented

I'll look to it

alekseyl commented

I think such
.split(/,[\s$]*/) would be enough

alekseyl commented

done in all gem versions