Works fine on 5.2.4.2
gduprey opened this issue · 1 comments
Just getting around to upgrading to Rails5 (and eventually, rails6) and upgraded to Rails 5.2.42 and rails_select_on_includes 5.2.1 (which appears to be the latest).
We used this amazing gem under Rails4 for over 40% of our model querying (we have a lot of postgresql DB functions) and it always worked great.
With the current rails/gem version, when I add a virtual attribute for a non-joined/eager-loaded query, the virtual attributes are created as normal. As soon as I add a eager_load to the join, the virtual attributes are not available on the primary model (i.e everything acts like before select_on_includes was present).
Is it possible some post rails 5.2.1 change broke this?
At the moment, we cannot go to Rails 6 as a number of the gems we depend on have not yet been updated for it.
This was actually due to another patch we had being monkey-patched for Rails4 problem (that was fixed in Rails5). Removing this monkey patch proved that 1) we no longer needed it for the original problem and 2) it was break rails_select_on_includes.
It does work as it always has for rails 5.2.4.2
Sorry for the false alarm and thanks again for an amazing piece of work!!