aleveille/octant-dashboard-turnkey

service port is incorrect

maxisam opened this issue · 4 comments

maxisam commented

first of all, thanks for the awesome project

I think the port here is wrong. it should point to 8000 instead.

octant-dashboard-turnkey/helm/templates/ingress.yaml

Line 39 in ecfad25

servicePort: http

aleveille commented

Hi @maxisam,

Thansk for reporting this. It seems to work OK on my setup, are you having issues with this?

It's using the name of the service port (which is http, https://github.com/aleveille/octant-dashboard-turnkey/blob/master/helm/templates/service.yaml#L17)

Let me know if it's causing you issues. While I'm using it successfully, it might differ based on the API version.

maxisam commented

Interesting, I don't know if the name matters

octant-dashboard-turnkey/helm/templates/service.yaml

Line 10 in ecfad25

- port: {{ .Values.service.port }}

And I think it is set by this, which is 8000

aleveille commented

I see. Yes I tend to use '8000' as the default port as my personal standard for ports in Kubernetes.

Would it make more sense to you if I used 8080 as the default port?

octant-dashboard-turnkey/helm/values.yaml

Line 35 in ecfad25

port: 8000

aleveille commented

I'll be closing this issue. Feel free to reach out in the future!