alex-cory/react-useportal

Package adding unnecessary empty divs

Sebastp opened this issue · 6 comments

Can we somehow prevent this package from adding empty divs to the end of the body on init?

Untitled-1

we can. I've been working on a way to have the portal only have 1 div it's working with for all portals on the page. I just haven't had time yet.

we can. I've been working on a way to have the portal only have 1 div it's working with for all portals on the page. I just haven't had time yet.

ok, thanks

Any news on that? I really need this fixed. Can I help you in any way to make it done?

Feel free to submit a PR! Sorry for the delay. I have been crazy busy

Guys check my pr, this should work.

btw, I think found an error in the example here, there should be an event passing to the openSecondPortal right? If so I can fix it in my PR.