Add labels to the activities view
idealist1508 opened this issue · 3 comments
I really like labels in ActivityLog2. Usability of labels can be further improved by displaying them in table on activities view:
What do you think? I could try to implement this and make PR.
How do you run test? Do you use code coverage?
Implementing this task requires familiarity with both SQL and Racket. I don't have time to work on it in the short to medium term, but if you want to give it a go, here is what needs to be done:
- Update the V_ACTIVITY_LIST view to include an entry for the labels from the SESSION_LABEL table. This needs to be a database migration, as explained in the database notes.
- add an entry for the new column of the view to activity-list-display-columns
- update the set-session-tags method to also post an
session-updatedevent that the session ID has changed, as explained in gui-consistency.md -- this will ensure that the entry in the list is updated when the user edits the labels.
In practical terms, you want to first back up your database, than update V_ACTIVITY_LIST directly using any SQLite tool -- I am using the sqlite command utility from Emacs. This will allow to experiment with the view creation code and the rest of the Racket changes before you write the database migration.
With regards to the test suite, the tests are in the tests/ sub-folder, and you can run them using commands such as "raco test tests/db-test.rkt". Note however that some tests require data which is private (my own training data), as such, while they will run on your machine, you won't be able to actually test anything. This is explained in the README.md document.
There is no test coverage set up.
Thanks for working on this feature. I now merged the pull request, and will close this issue.