alex-okrushko/backoff-rxjs

Change to es2015 modules broke nodejs project

Closed this issue · 2 comments

gregjacobs commented

Hey @alex-okrushko. I see you changed to es2015 modules output, but that doesn't work at least under node 8. We get this syntax error:

(function (exports, require, module, __filename, __dirname) { export { retryBackoff } from './operators/retryBackoff';
                                                              ^^^^^^

If you would like to deliver es2015 modules, then you should create an additional build for that. In package.json, your "main" entry should refer to the commonjs output for nodejs, and you can add a "module" entry to refer to es2015 output for build tools like webpack, the Angular compiler, etc.

Here's an example: https://github.com/gregjacobs/Autolinker.js/blob/master/package.json#L7

alex-okrushko commented

@gregjacobs Thanks a lot for the issue report. Could you please try 6.3.2 ? It should support all kinds of module systems.

gregjacobs commented

Thanks @alex-okrushko, 6.3.2 worked!

I see you put quite a bit of work into that. Thanks for that and the quick turnaround!

  • 👍1