Add make format and make check-codestyle to git pre-commit
alex-petrenko opened this issue · 2 comments
alex-petrenko commented
I recently updated the whole codebase to use black and isort formatting @edbeeching
Since we've now automated code formatting, it makes sense to do it every time code is being committed to VCS.
Here's a short instruction I found that may be helpful: https://ljvmiranda921.github.io/notebook/2018/06/21/precommits-using-black-and-flake8/
If we could make it such that anyone who clones the repo automatically gets the pre-commit hook, it'd be awesome.
@wmFrank since you are a king of CI, can you please do this thing? Not a very high priority, but ideally this should be done in the next few days.
wmFrank commented
Sounds good, I'll try it.
alex-petrenko commented
We also need to add make check-codestyle
to CI checks alongside tests :)