alexa-samples/skill-sample-python-audio-player

[MultiStream] data.CANNOT_SKIP_MSG missing

frivas opened this issue · 0 comments

Hello,

I was just checking this skill and going through the code I saw this:

class NextOrPreviousIntentHandler(AbstractRequestHandler):
    """Handler for next or previous intents."""
    def can_handle(self, handler_input):
        # type: (HandlerInput) -> bool
        return (is_intent_name("AMAZON.NextIntent")(handler_input) or
                is_intent_name("AMAZON.PreviousIntent")(handler_input))

    def handle(self, handler_input):
        # type: (HandlerInput) -> Response
        logger.info("In NextOrPreviousIntentHandler")
        _ = handler_input.attributes_manager.request_attributes["_"]
        handler_input.response_builder.speak(
            _(data.CANNOT_SKIP_MSG)).set_should_end_session(True)
        return handler_input.response_builder.response

What I had found odd was the in data.py there is no CANNOT_SKIP_MSG. Am I missing something here?.

Thank you very much in advanced.

[Update]: I can see now. Just checked the same file and class in the SingleStream code and, because it is a radio, you cannot skip therefore that message should be there, however I am afraid that for podcasts it should be possible to play next and previous episodes, right?. Thanks again.

[Update#2]: Just saw there is a verification of a playback session for the AMAZON.NextIntent and AMAZON.PreviousIntent , when there is a play back session then it is possible to play next and previous. Thanks again :D