Missing py.typed on pypi.org
gnuletik opened this issue · 4 comments
I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:
Expected Behavior
PR #74 added py.typed empty files on the project's packages according to PEP 561 to allow mypy to lint the SDK call's.
On this repo, the file is located here : https://github.com/alexa/alexa-skills-kit-sdk-for-python/blob/master/ask-sdk-core/ask_sdk_core/py.typed
On the Github's release, the file is located here: /alexa-skills-kit-sdk-for-python-1.11.0/ask-sdk-core/ask_sdk_core/py.typed
https://github.com/alexa/alexa-skills-kit-sdk-for-python/archive/1.11.0.zip
On pypi.org, the last release (1.11.0) of ask-sdk-core package should have a py.typed file.
Current Behavior
The py.typed file is not in the pypy.org release as you can see here: https://pypi.org/project/ask-sdk-core/1.11.0/#files
Possible Solution
Are empty files removed during the deployment pipeline / CD ?
Steps to Reproduce (for bugs)
$ python3 -m venv py-typed-test
$ source py-typed-test/bin/activate
$ pip install 'ask-sdk-core>=1.11.0'
$ ls py-typed-test/lib/python3.7/site-packages/ask_sdk_core/py.typed
ls: cannot access 'py-typed-test/lib/python3.7/site-packages/ask_sdk_core/py.typed': No such file or directory
Context
Trying to use mypy.
Your Environment
- ASK SDK for Python used: 1.11.0
- Operating System and version: Debian 10
Python version info
- Python version used for development:
Python 3.7.3
pip 18.1
@gnuletik Sorry for the late response. It looks like that file was excluded when creating the distributable files. Since there are couple other PR's that are being reviewed at the moment, once they are done, we will release a patch containing the file. Thanks for raising this issue.
Hey @gnuletik , I worked a bit on this before the SDK release today. There seems to be some conflicts between the type hints we provide in the ask-sdk-runtime and ask-sdk-core packages. Particularly with the request_components modules having different input/output types in both the packages.
I think we need to generify the input/output types in the runtime package since this package is the base layer for the sdk, and have to instantiate derived types in core package. This needs some investigation. I will circle back soon with the fix. Sorry again and thanks for being patient.
The fix has been released on 1.13.0 version. Closing this. Please reopen if you still face problems. Thanks !!