build.sh replaces any installed node_modules

Question

Closed this issue 5 years ago · 1 comments

The default build.sh has a git add . && git reset --hard HEAD that subtly will remove any other installed packages from the build directory.

Scala.js can require you to npm install jsdom which will get nuked and the test runner fail.

This probably needs either a comment or ensure node_modules is part of the default .gitignore?

I think there is an outstanding Scala.js bug somewhere that requires a local install and doesn't work with the global install of the package.

Answer 1 · 2020-07-08T13:09:34.000Z

We should add node_modules as part of .gitignore.

And we should probably get rid of that git reset --hard HEAD.