alexcorre/git-blame

Git blame error when toggling git blame and no url template string is set

aake opened this issue · 8 comments

aake commented

I don't have custom commit url template string set and my projects are hosted on our on git server with no http(s) access.

When I hit ctrl-b to toggle git blame I get the error popup I previously only saw when trying to click on a certain commit in the git blame drawer. The git blame drawer is not shown.

This was working before the 0.3 release.

alexcorre commented
  1. Do you get just one popup? or many that you have to dismiss?
  2. Also can you please provide the exact error message and what your origin remote url looks like? git remote -v
  3. since your git server does not have http web interface, is there something else you'd like to happen when clicking on the hash? I'm sure many users have this issue.
aake commented
  1. Just one popup, but it happens on each toggle try.
    • Error message:
      "Git Blame Error: Woops! It looks like you didn't enter a Custom Commit Url Template String in the package settings. Please do so in order to open commit hashes for repos that are not hosted on Github or Bitbucket."
    • Remote url:
      origin git@git.somecompany.com:someproject.git
  3. The very similar git blame plugin for sublime opens the corresponding commit as a new tab when clicking the hash. I think that's a reasonable behavior.

Let me know if you need more info. Thanks!

kaspereden commented

I indeed am facing the same issue, the weird thing is that it used to work until a few days ago...

alexcorre commented

@kaspereden I released version 0.3.0 a few days ago which introduced this bug so thats why you just started seeing it.

The major change here is that we now generate the urls ahead of time so that we can use a simple <a> tag in the markup, rather than generating the url on click. This is much cleaner way of doing things but unfortunately introduced this issue for non supported remote url. I'll get a fix in for this this afternoon or sometime this weekend.

I the meantime, feel free to downgrade to the previous version to get rid of this bug temporarily.

alexcorre commented

@kaspereden @aake releasing v0.3.2 with the fix now

RossBarnie commented

Fixed after restart, thanks!

kaspereden commented

Same here, thanks 👍

aake commented

Thanks a lot @alexcorre!