alexei/sprintf.js

Add/Improve .npmignore

SimonSchick opened this issue · 1 comments

You are shipping redundant files:

node_modules/sprintf-js/
node_modules/sprintf-js/bower.json
node_modules/sprintf-js/gruntfile.js
node_modules/sprintf-js/demo/
node_modules/sprintf-js/demo/angular.html
node_modules/sprintf-js/test/
node_modules/sprintf-js/test/test.js

For some reason the latest publish of your package contains a .npmignore file that only contains node_modules.

$ wc -c node_modules/sprintf-js/bower.json node_modules/sprintf-js/gruntfile.js node_modules/sprintf-js/demo/angular.html node_modules/sprintf-js/test/test.js
 439 node_modules/sprintf-js/bower.json
 970 node_modules/sprintf-js/gruntfile.js
 690 node_modules/sprintf-js/demo/angular.html
3746 node_modules/sprintf-js/test/test.js
5845 total

$ tar -czf out.tar.gz node_modules/sprintf-js/bower.json node_modules/sprintf-js/gruntfile.js node_modules/sprintf-js/demo/angular.html node_modules/sprintf-js/test/test.js

$ wc -c out.tar.gz
1767 out.tar.gz

I suggest you do this given your modules gets installed roughly ~5.000.000x a week, assuming the specified files have a compressed (tar.gz) size of 1767 bytes, this is a total of 10.3gb/week of wasted network traffic.

Fixed