alexfernandez/loadtest

Callback function is not called by anyone, possible dead code

damianpumar opened this issue · 2 comments

damianpumar commented

I am creating a load test, and I am trying to see the results of a specific request and I cannot. I think the callback function is not being used.
In that case, I can fix it.

https://github.com/alexfernandez/loadtest/blob/main/lib/loadtest.js#L101-L114

alexfernandez commented

I am investigating the issue. You are right, it needs to be restored, but I will have to change the interface and remove the latency parameter because it would slow it down too much. I hope it's OK!

alexfernandez commented

Fixed in #220, beware because the interface has changed to statusCallback(error, result).

Released as v7.0.0.

  • 👍1