AWS Location Service adapter does not store raw response in @data
woodhull opened this issue · 1 comments
woodhull commented
Expected behavior
While using AWS Location Service adapter, it should be possible to access the data property of responses using the data
accessor.
Actual behavior
Geocoder::Result::AmazonLocationService stores the response in a @place
variable while the base class expects the variable to be named @data
https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/amazon_location_service.rb
vs
https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/base.rb#L6
Steps to reproduce
Geocode results from AWS Location service are correct for the common attributes, but calling data
always returns nil.
Environment info
- Geocoder version:
- Rails version:
- Database (if applicable):
- Lookup (if applicable):
alexreisner commented
Whoops! Thanks for this. The Result class should not define an initialize
method. Open to a pull request. (cc @mplewis)