alexweininger/recent-pdf

Improve file icon appearance

alexweininger opened this issue · 10 comments

alexweininger commented

Improve file icon appearance

  • As of now the icons are not properly aligned vertically with the file name.
  • They also could be a bit larger to fit in with the file name font size.

image

jmannfeld commented

I can work on this

  • 👍1
alexweininger commented

@jmannfeld go for it!

Feel free to discuss what you're planning to do with me!

jmannfeld commented

Is there a good way to inspect a plugin in chrome?

alexweininger commented

@jmannfeld The way I have always done it is just right click on the popup and inspect it from there. It is annoying since when you click away, the popup and the dev tools close.

Are you asking about that or about how to add RecentPDF to chrome so you can test it while developing?

jmannfeld commented

Yep, I was asking about inspecting the styles. I will try that

  • 👍1
jmannfeld commented

How's this?
recent-pdf

  • 🎉1
alexweininger commented

Looks amazing! @jmannfeld 👍 😃 🎉

If you're ready, you can PR and I'll take a look at it locally.

Thanks!

I see you don't have a fork of recent-pdf, you can fork it then push the changes there so I can view them.

  • 😄1
jmannfeld commented

Thanks! 😀 Never worked on an extension before. Nice app!

  • 🎉1
alexweininger commented

Love the support! I encourage you to keep contributing!