Unset `restclient-response-loaded-hook` when executing

[ivan-m]

I've copied the jordon-restclient-delete-headers-when-ok and pulse-entire-buffer hook functions from this config

  (add-hook 'restclient-response-loaded-hook
            (defun jordon-restclient-delete-headers-when-ok ()
              (when (equal major-mode 'js-mode)
                (save-excursion
                  (goto-char (point-max))
                  (when (and (search-backward "200 OK" nil t)
                             (search-backward "}" nil t))
                    (forward-char 1)
                    (delete-region (point) (point-max))
                    (json-mode))))))
  (add-hook 'restclient-response-loaded-hook
            (defun pulse-entire-buffer ()
              (save-excursion
                (goto-char (point-min))
                (pulse-momentary-highlight-region (point-min) (point-max)))))

When using it in conjunction with ob-restclient.el, they seem to cause issues however:

#+begin_src restclient
GET https://jsonplaceholder.typicode.com/posts/1
#+end_src

#+RESULTS:
#+BEGIN_SRC json
{
  "userId": 1,
  "id": 1,
  "title": "sunt aut facere repellat provident occaecati excepturi optio reprehenderit",
  "body": "quia et suscipit\nsuscipit recusandae consequuntur expedita et cum\nreprehenderit molestiae ut ut quas totam\nnostrum rerum est autem sunt rem eveniet architecto"
}#+END_SRC

Once I unset this hook, then it works as intended

#+begin_src restclient
GET https://jsonplaceholder.typicode.com/posts/1
#+end_src

#+RESULTS:
#+BEGIN_SRC js
{
  "userId": 1,
  "id": 1,
  "title": "sunt aut facere repellat provident occaecati excepturi optio reprehenderit",
  "body": "quia et suscipit\nsuscipit recusandae consequuntur expedita et cum\nreprehenderit molestiae ut ut quas totam\nnostrum rerum est autem sunt rem eveniet architecto"
}
// GET https://jsonplaceholder.typicode.com/posts/1
// HTTP/1.1 200 OK
// Date: Tue, 14 Jan 2020 09:45:47 GMT
// Content-Type: application/json; charset=utf-8
// Transfer-Encoding: chunked
// Connection: close
// Set-Cookie: __cfduid=de6c4ea92fcd0cf991787ded6b4633df01578995147; expires=Thu, 13-Feb-20 09:45:47 GMT; path=/; domain=.typicode.com; HttpOnly; SameSite=Lax
// X-Powered-By: Express
// Vary: Origin, Accept-Encoding
// Access-Control-Allow-Credentials: true
// Cache-Control: max-age=14400
// Pragma: no-cache
// Expires: -1
// X-Content-Type-Options: nosniff
// Etag: W/"124-yiKdLzqO5gfBrJFrcdJ8Yq0LGnU"
// Via: 1.1 vegur
// CF-Cache-Status: HIT
// Age: 5609
// Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
// Server: cloudflare
// CF-RAY: 554eadd5ff2fd9cc-SIN
// Content-Encoding: gzip
// Request duration: 0.396270s
#+END_SRC

This might be connected to #17

[alf]

Is the issue here the missing line break before end_src?

[ivan-m]

Primarily so, yes.

I couldn't reproduce it here, but the first time I ran it it also got surrounded in #+begin_example ... #+end_example.

[ivan-m]

I'm going to close this in favour of #17 as adding (newline) to the end of my hook seems to make it work; I think the execution needs to check if the captured output has a blank line at the end or not before appending #+END_SRC.