Remove unused (partial) files from the destination folder

Question

Remove unused (partial) files from the destination folder

Closed this issue 3 years ago · 5 comments

I know, this somewhat contradicts the idea of .partial in #28, but now when we have the status, I thought maybe we can download to a Temp folder, and move to the destination folder when the download completed?

The download destination folder can be shared with other programs, since it is our program output, so the .partial solution was good, but I think it is better to use a Temp folder.

Another option, I don't want to open another issue about that because I think if we implementing the Temp folder, we don't need it, is to add a clean command to remove the unhandled .partial files.

All my issues are because my system is unstable, so my daemon is sometimes restarting and lose its download processes.

Answer 1 · 2021-01-13T19:03:35.000Z

Perhaps we could merge both behaviours. With a combination two command line parameters: "destination folder" and "temporary folder" we can solve these use cases:

Temporary folder not specified or equal to Destination folder: current behaviour. Files are downloaded to Destination Folder (with the .partial ending) and renamed after completion.
Temporary folder different to Destination Folder: Files are downloaded to Temporary Folder (with the .partial ending) and moved to the Destination folder after completion.

Answer 2 · 2021-01-21T18:34:09.000Z

Actually, in #28, I had suggested temp directory (named partials in my text). So, I wouldn't exactly call it to be conflicting with #28. I'm ok with that approach too.
I was not in favour of sharing the temp directory, to avoid potential file name conflicts with other programs. But if we keep the suffix specific to this daemon (instead of genetic like partial), I think the conflicts can be minimised.

Answer 3 · 2021-01-27T16:56:06.000Z

I have added a new parameter --temp to point at a temporary directory. I have also changed the suffix for partially downloaded files to ".tdd".

I think we cover all the cases with this, don't we?

Answer 4 · 2021-01-27T17:07:22.000Z

Thanks!

Now just want the clean command. It is not so necessary, since when everything is almost good it will clean almost nothing.
But if my connection is bad, for example, this folder might get a lot of files.

Answer 5 · 2021-02-08T17:43:14.000Z

Now just want the clean command. It is not so necessary, since when everything is almost good it will clean almost nothing.

Done!