algolia/algoliasearch-client-php

Messed up getApiKey()

szepeviktor opened this issue · 3 comments

szepeviktor commented

I think wrong getApiKey is called: SearchClient vs. Config/AbstractConfig

 ------ --------------------------------------------------------------------------------------------------------
  Line   Response/DeleteApiKeyResponse.php
 ------ --------------------------------------------------------------------------------------------------------
  45     Method Algolia\AlgoliaSearch\Config\AbstractConfig::getApiKey() invoked with 2 parameters, 0 required.
 ------ --------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------
  Line   Response/RestoreApiKeyResponse.php
 ------ --------------------------------------------------------------------------------------------------------
  56     Method Algolia\AlgoliaSearch\Config\AbstractConfig::getApiKey() invoked with 2 parameters, 0 required.
 ------ --------------------------------------------------------------------------------------------------------

Please consider having robust code:

composer require guzzlehttp/guzzle
phpstan analyze -l max -a src/functions.php src/
nunomaduro commented

It's in our plans to add development quality tools: #519. Maybe you would help us hear? Something to keep in mind is that we still support PHP 5.3.

Meanwhile here are the fixes for your issue:

  1. #552.
  2. #551.
szepeviktor commented

👂
Thank you!

  • ❤️1
nunomaduro commented

It's always a pleasure to work with you buddy.