algolia/autocomplete

Body scroll should be restored when detached mode is responsively removed

aldenquimby opened this issue · 4 comments

aldenquimby commented

Description

Body scroll should be restored when detached mode is responsively removed

Reproduction

Preview → - default sandbox has the bug

Steps

  1. Go to default sandbox
  2. Set a wide viewport so you do not have detached mode to start
  3. Open search panel and notice scrolling the page works
  4. With search panel open, decrease your viewport so detached mode is turned on
  5. With search panel still open, increase your viewport so detached mode is turn off
  6. Notice scrolling the page is now broken

algolia

Expected behavior

  • scrolling the page should work when detached mode is off

Environment

  • OS: [e.g. Windows / Linux / macOS / iOS / Android]: macOS
  • Browser: [e.g. Chrome, Safari]: Chrome latest
  • Autocomplete version: [e.g. 1.0.0]: 1.17.0
career-tokens commented

I am interested in taking this up. I checked the sandbox and opened the app in a new tab. For large screen, you can scroll the entire page but for mobile view or smaller screen, somehow the scroll event is not getting activated.

career-tokens commented

One solution I can think of can't we keep the cancel button even in big screen? Like in my opinion, its still pretty frustating that I can't close the search menu after opening it. I guess we can keep a backdrop in the background when opening the search bar so as to let the user know they can't make change in the background before making their search.

aldenquimby commented

@career-tokens I have a fixed posted on #1251

My team is using a forked version based on that fix in production, and all is well. Waiting on code review + tests and hopefully it will merge soon

career-tokens commented

Thanks for letting me know. I don't know whether I should ask it here but can you let me know whether you have NextJS based repositories with good first issues?